Skip to content

feat: Add Formats and Fields to server_definitions#6321

Open
godexsoft wants to merge 59 commits intoXRPLF:developfrom
godexsoft:feature/flags-server-definitions
Open

feat: Add Formats and Fields to server_definitions#6321
godexsoft wants to merge 59 commits intoXRPLF:developfrom
godexsoft:feature/flags-server-definitions

Conversation

@godexsoft
Copy link
Collaborator

@godexsoft godexsoft commented Feb 3, 2026 •
edited by ximinez
Loading

High Level Overview of Change

Closes #5151
Attempts to implement XRPLF/XRPL-Standards#418

This is a combination of #5702 (bulk of functionality) and #5616 (tests).

If merged:

  • Issue with tfBatchMask not matching the previous constant is fixed and covered by an extra test in Batch_test.cpp.
  • Modernized the code where possible, removed incorrect uses of initializer_list where applicable.

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

mvadari and others added 30 commits August 16, 2025 13:33
@mvadari
first stab
e736965
@mvadari
move server_definitions to new file
c91afc0
@mvadari
move AccountSet to app
491c6ec
@mvadari
[WIP] flags
acac1c9
@mvadari
finish flags
97a2912
@mvadari
clean up
945c5fd
@mvadari
add universal flags
7c4d63b
@mvadari
split out common fields
34fdea9
@mvadari
Merge remote-tracking branch 'upstream/develop' into server_definitions2
a8b0043
@mvadari
fix flags
cbecdb2
@mvadari
fix flags
38a29ab
@mvadari
Merge branch 'develop' into server_definitions2
034198e
@mvadari
Merge remote-tracking branch 'upstream/develop' into server_definitions2
fa0d5a6
@mvadari
Merge branch 'develop' into server_definitions2
09ec4ef
@mvadari
Merge branch 'develop' into server_definitions2
85b015b
@mvadari
Merge branch 'develop' into server_definitions2
b84a348
@mvadari
add lsf flags
edb04af
@mvadari
Merge branch 'develop' into server_definitions2
7a4d423
@mvadari
Merge branch 'develop' into server_definitions2
3e1661b
@mvadari
Merge branch 'develop' into server_definitions2
b51292b
@mvadari
Merge branch 'develop' into server_definitions2
e5d6f02
@mvadari
match spec
de9777d
@mvadari
Merge branch 'develop' into server_definitions2
cf9b68c
@mvadari
fix build issue
7753f93
@mvadari
Merge branch 'develop' into server_definitions2
7e7f497
@mvadari
Merge branch 'develop' into server_definitions2
571950d
@mvadari
Merge branch 'develop' into server_definitions2
a2c0fdc
@mvadari
Merge branch 'develop' into server_definitions2
1e4596d
@mvadari
Merge commit '92046785d1fea5f9efe5a770d636792ea6cab78b' into server_d…
70ff709 
…efinitions2
@mvadari
Merge branch 'develop' into server_definitions2
498d533
Copilot AI review requested due to automatic review settings February 20, 2026 15:19

This comment was marked as resolved.

Sign in to view

@godexsoft godexsoft self-assigned this Feb 22, 2026
@godexsoft godexsoft added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Feb 22, 2026
@mvadari mvadari mentioned this pull request Feb 24, 2026
Closed
13 tasks
Copilot AI review requested due to automatic review settings February 25, 2026 00:10

This comment was marked as resolved.

Sign in to view

ximinez
ximinez requested changes Feb 25, 2026
View reviewed changes
Copy link
Collaborator

@ximinez ximinez left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is marked as "Ready to merge", but it's not clear to me that all of @mvadari's questions have been addressed.

In addition, I took a skim through the PR, and noticed a couple of possible improvements.

@ximinez ximinez removed the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Feb 25, 2026
@mvadari mvadari added the Blocked: Needs Final XLS The corresponding final XLS must have been merged before this PR is merged. label Feb 25, 2026
@godexsoft godexsoft requested review from mvadari and ximinez February 26, 2026 19:16
@godexsoft godexsoft added Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. and removed Blocked: Needs Final XLS The corresponding final XLS must have been merged before this PR is merged. labels Mar 2, 2026
Copilot AI review requested due to automatic review settings March 2, 2026 21:38
Copilot AI reviewed Mar 2, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 29 out of 29 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

API-CHANGELOG.md
Comment on lines +25 to +31
## XRP Ledger server version 3.2.0

[Version 3.2.0](https://github.com/XRPLF/rippled/releases/tag/3.2.0)

### Additions in 3.2.0

- `server_definitions`: Added the following new sections to the response ([#6321](https://github.com/XRPLF/rippled/pull/6321)):
Copy link

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This new changelog entry for "XRP Ledger server version 3.2.0" doesn’t include a release date, while the surrounding entries do. Please either add the release date (if known) or adjust the heading/link text to match the established format used in this file for unreleased/new versions.

Copilot uses AI. Check for mistakes.
ximinez
ximinez previously approved these changes Mar 4, 2026
View reviewed changes
Copy link
Collaborator

@ximinez ximinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of my concerns have been addressed, though Copilot identified a couple of things.

@ximinez ximinez dismissed their stale review March 4, 2026 22:22

I haven't done a deep review, so I'm just going to dismiss this approval. There are plenty of other approvals to proceed with.

godexsoft and others added 2 commits March 5, 2026 10:39
@godexsoft
Update LedgerFormats.h
4636d15 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@godexsoft
Update ServerDefinitions_test.cpp
12e5bb9 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vvysokikh1 vvysokikh1 vvysokikh1 approved these changes

Copilot code review Copilot Copilot left review comments

@mvadari mvadari mvadari approved these changes

@kuznetsss kuznetsss kuznetsss approved these changes

@ximinez ximinez ximinez left review comments

Assignees

@godexsoft godexsoft

Labels

Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add transaction and ledger entry formats to server_definitions

6 participants

@godexsoft @ximinez @mvadari @kuznetsss @vvysokikh1